Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unit tests #1635

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Clean up unit tests #1635

merged 1 commit into from
Dec 24, 2021

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 23, 2021

This PR is an initial work for refactoring of the DART testing, including:

  • Add dart_build_tests() to easily define tests
  • Add subdirectories for unit test for each namespace (e.g., unittest/unit/common and unittest/unit/math)
  • Rename comprehensive test to integration test
  • Move "unit" tests that test more than one namespace to integration tests

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve build warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.13.0 milestone Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1635 (ba5c42d) into main (09935e5) will increase coverage by 0.02%.
The diff coverage is 73.91%.

@@            Coverage Diff             @@
##             main    #1635      +/-   ##
==========================================
+ Coverage   58.95%   58.98%   +0.02%     
==========================================
  Files         483      485       +2     
  Lines       40252    40272      +20     
==========================================
+ Hits        23732    23754      +22     
+ Misses      16520    16518       -2     
Impacted Files Coverage Δ
dart/common/CAllocator.cpp 71.11% <0.00%> (-0.99%) ⬇️
dart/common/detail/StlAllocator-impl.hpp 94.11% <94.11%> (ø)
dart/common/StlAllocator.hpp 100.00% <100.00%> (ø)
dart/common/MemoryAllocator.cpp 27.27% <0.00%> (+27.27%) ⬆️
dart/common/CAllocator.hpp 100.00% <0.00%> (+100.00%) ⬆️

@jslee02 jslee02 force-pushed the test_dir branch 2 times, most recently from 655853a to a77cbd6 Compare December 23, 2021 22:06
@jslee02 jslee02 marked this pull request as ready for review December 24, 2021 02:46
@jslee02 jslee02 merged commit 8eb7688 into main Dec 24, 2021
@jslee02 jslee02 deleted the test_dir branch December 24, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant