Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depth rendering mode #1652

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Add depth rendering mode #1652

merged 2 commits into from
Jan 20, 2022

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 20, 2022

Usage:

auto viewer = dart::gui::osg::Viewer();
viewer.setCameraMode(dart::gui::osg::CameraMode::DEPTH);  // or dart::gui::osg::CameraMode::RGBA (default)

RGBA mode:
image

Depth mode
image


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02 jslee02 added this to the DART 6.13.0 milestone Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1652 (ea604f9) into main (90712b1) will increase coverage by 0.01%.
The diff coverage is 26.47%.

❗ Current head ea604f9 differs from pull request most recent head 4f84694. Consider uploading reports for the commit 4f84694 to get more accurate results

@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
+ Coverage   59.14%   59.15%   +0.01%     
==========================================
  Files         499      499              
  Lines       40911    40915       +4     
==========================================
+ Hits        24195    24202       +7     
+ Misses      16716    16713       -3     
Impacted Files Coverage Δ
python/dartpy/gui/osg/ImGuiViewer.cpp 64.28% <0.00%> (ø)
python/dartpy/gui/osg/Viewer.cpp 59.06% <27.27%> (+1.39%) ⬆️
dart/collision/detail/UnorderedPairs.hpp 95.00% <0.00%> (+5.00%) ⬆️

@jslee02 jslee02 marked this pull request as ready for review January 20, 2022 05:13
@jslee02 jslee02 merged commit 7f5e3fd into main Jan 20, 2022
@jslee02 jslee02 deleted the depth_cam branch January 20, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant