This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
Handle dvm display issues #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boundless-forest
requested review from
aurexav,
clearloop,
hackfisher and
yanganto
as code owners
boundless-forest
force-pushed
the
handle-decimal-dvm
branch
3 times, most recently
from
e2e4170 to
310c15b
Compare
|
Ready for review? If not remove the label. |
Wait minutes, I am working on fixing the conflict and rebase to the latest |
|
What's the substrate PR link? |
Please check this commit firstly: darwinia-network/substrate@50a2e0c. If you all approve this pr modification, then, I will raise the substrate pull request. |
boundless-forest
force-pushed
the
handle-decimal-dvm
branch
from
310c15b to
4a41e54
Compare
boundless-forest
force-pushed
the
handle-decimal-dvm
branch
from
4a41e54 to
9506b4b
Compare
aurexav
reviewed
Nov 4, 2020
aurexav
reviewed
Nov 4, 2020
aurexav
reviewed
Nov 4, 2020
boundless-forest
force-pushed
the
handle-decimal-dvm
branch
from
e45971a to
4836e2f
Compare
boundless-forest
force-pushed
the
handle-decimal-dvm
branch
from
4836e2f to
9dcf0d5
Compare
hackfisher
suggested changes
Nov 5, 2020
|
Related commit changes to substrate: darwinia-network/substrate@50a2e0c |
boundless-forest
force-pushed
the
handle-decimal-dvm
branch
from
9f35bee to
005ba87
Compare
|
@hackfisher @AurevoirXavier Please take some time to check this PR again. |
hackfisher
approved these changes
Nov 9, 2020
@AurevoirXavier Please help review and merge this pull request, thanks. |
boundless-forest
force-pushed
the
handle-decimal-dvm
branch
from
5407b0d to
c83d039
Compare
aurexav
approved these changes
Nov 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
Note: This PR based on #334
Review Suggestion
Two commits:
The first commit just replaces the pallet-evm path to facilitate testing, you can jump directly to the second.
To see the corresponding evm pallet change, please refer to This link