Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Bump astroid from 2.1.0 to 2.2.0 in /requirements #148

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps astroid from 2.1.0 to 2.2.0.

Changelog

Sourced from astroid's changelog.

What's New in astroid 2.2.0?

Release Date: 2019-02-27

  • Fix a bug concerning inference of calls to numpy function that should not return Tuple or List instances.

Close pylint-dev/pylint#2436

... (truncated)
Commits
  • 9eddca3 When picking the parse function, make sure to parse with the right minor version
  • 87db3f5 Disable test that does not make sense on versions older than Python 3.6
  • 9b6445d Prepare 2.2.0
  • e5fe824 Remove merge marker
  • cee7875 Don't clear the manager caching any longer
  • 08cbcba Use the right pytest methods for setup and teardown
  • f6310d8 Use the same versions in tox as in pkginfo
  • 16b70e3 Added 2 more missing _ssl constants (#648)
  • 67f7daa Merge pull request #643 from hippo91/bug_pylint_2436
  • bb10f80 Merges master
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Feb 27, 2019
Copy link
Owner

@das7pad das7pad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to move to python version specific requirements files.

@@ -70,7 +70,7 @@ soupsieve==1.8
spotipy==2.4.4
tqdm==4.31.1
twitterapi==2.5.9
typed-ast==1.3.1
typed-ast==1.2.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's odd. pip-compile does not forward the environment marker from astroids install_requires [1].

[1] https://github.com/PyCQA/astroid/blob/8a3d8b908da5d80c7bf6857d94333e7c87b5c176/astroid/__pkginfo__.py#L33

@das7pad
Copy link
Owner

das7pad commented Mar 1, 2019

Hi @greysteil!

base on the diff in this PR and this snippet from astroid, you seem to be using a python version below 3.7 for dependabot. pip-compile continues with the packages that pass the constrains check in the current environment. In this case it has an influence on the picked version for typed-ast.

Discussion on this is here and there.
TL;DR: pip-compile is not (yet) able/willing to support multiple environments.

What do you think about multiple python versions one could pick from for dependabot?

Cheers!

@greysteil
Copy link

Hmmm. Dependabot actually runs multiple Pythons - if you add a .python-version file to this repo it will use whatever is specified there.

@das7pad
Copy link
Owner

das7pad commented Mar 1, 2019

Thank you for your response. I will give it a try, once we agree on a specific version!

Note: The .python-version file does not seem to be documented [1].
Btw: The google search reviled this issue https://github.com/dependabot/feedback/issues/288 instead. The project referenced in the #288 could profit from two requirements files: one for py2.7 and one for py3. A config option for the python version would be better suited then.

[1] https://www.google.com/search?q=dependabot+".python-version"

@dependabot-preview
Copy link
Contributor Author

Superseded by #153.

@dependabot-preview dependabot-preview bot deleted the dependabot/pip/requirements/astroid-2.2.0 branch March 2, 2019 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.