fix: Fix project codes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@subotic Any idea why the Travis build fails? |
lrosenth
approved these changes
Sep 3, 2019
|
@lrosenth Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some project codes so they correspond to the ones exported from PHP SALSAH. Since this produces some conflicting project codes, some others have to be changed as well.
@lrosenth sent me this list of all projects in PHP SALSAH:
Most of these codes conflicted with codes assigned in
shortcodes.csv. In all but one case, I changed the code of the other project, as follows:0806(lhtt->webern,lhttgot0820)080C(SGV_oldproject->kuhaba, I deletedSGV_oldprojectbecause it is apparently not needed)0811(digi-archives->postcards, I deleteddigi-archivesbecause Lukas said to do so)0812(elib->SGV,elibgot080F)0813(heidelberg->BMF,heidelberggot0823)0814(postcards->wackernagel,postcardsgot0811)0816(wackernagel->vitralis,wackernagelgot0814)0817(travis->Parzival,travisgot081D)0818(vitralis->bosnienfoto,vitralisgot0816)081B(dhlab-web->delille,dhlab-webgot081E)081C(smp->HdM,smpgot081A)081F(RTI->litfeuilleton,RTIgot0819)The exception is
0808, where there was a conflict betweendokubibandterlag. In the Knora test data,dokubibis0804. Lukas said it would be better to reassigndokubibthanterlag, so I changeddokubibto0804inshortcodes.csv, so we don't have to change the Knora test data.I also removed the values of
OLD SALSAH IDfromshortcodes.csvfor projects that are not in the above list.As far as I understand, if a project is not in PHP SALSAH (i.e. not in the above list) and is not live in Knora (i.e. not BEOL) its project code can be changed. So I changed some other project codes to remove gaps between codes. I made exceptions for
0825and0826, because they have entries indasch_ark_registry.ini.In
dasch_ark_registry.ini, I removed entries withUsePhp: truethat don't correspond to any project in the above list. I made an exception for0825, because it looks like it's supposed to be live onapp.langzeitarchivierung.ch(although that site is down).Does this make sense?