Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ontology responder should give clearer error message when cardinality cannot be parsed #157

Closed
sofiag opened this issue May 31, 2016 · 0 comments
Assignees
Labels
enhancement improve existing code or new feature
Milestone

Comments

@sofiag
Copy link

sofiag commented May 31, 2016

When a cardinality contains a malformed integer value, like this (the space after the 1 makes it invalid):

owl:minCardinality "1 "^^xsd:nonNegativeInteger

The ontology responder should throw a helpful exception instead of java.lang.NumberFormatException.

@sofiag sofiag added the enhancement improve existing code or new feature label May 31, 2016
@sofiag sofiag added this to the On Deck milestone May 31, 2016
benjamingeer pushed a commit that referenced this issue Jan 31, 2018
benjamingeer pushed a commit that referenced this issue Feb 7, 2018
* feature (webapi): After saving a property definition, reload it to check that it's correct.

* feature (webapi): Change a property's labels (ongoing).

* feature (webapi): Change a property's rdfs:label or rdfs:comment (ongoing).

* feature (webapi): Add route for changing labels or comments of a property.

- Add unit test for that.

* test (webapi): Add r2r tests for changing property labels and comments.

- Fix bugs in the comparison of SPARQL-escaped input with data read from the triplestore.

* feature (webapi): Add a class to an ontology (ongoing).

* feature (webapi): Add a class definition (ongoing).

* fix (webapi): Fix build and test breakage after merging develop into this branch.

* feature (webapi): Add a class to an ontology.

- Refactor SparqlExtendedConstructResponse to distinguish between blank nodes and IRIs.

* feature (webapi): Add a class definition.

- Refactor the ontology responder to calculate cardinality inheritance,
  and recalculate class hierarchies, when adding a class definition.
- Do more error-checking.
- Fix getClassDefinition.scala.txt not to return bogus blank nodes.
- Add a test.

* fix (webapi): Fix stupid bug.

* test (webapi): Add more tests of resource class creation, and fix more bugs.

- Cache abstract classes in OntologyResponderV2, and hide them when necessary in OntologyResponderV1.

* test (webapi): Create properties and classes.

- More tests.

* test (webapi): More property creation tests.

* feature (webapi): Add cardinalities to a class (ongoing).

- When creating a class or adding cardinalities, if new
  cardinalities override inherited ones, check that they
  are at least as restrictive.

* test (webapi): Add cardinalities to a class.

* feature (webapi): Change the labels or comments of a class (ongoing).

- Fix incorrect SPARQL-unescaping.

* test (webapi): Change the labels or comments of a class.

* feature (webapi): Change the labels or comments of a class.

- Add an e2e test for that.

* feature (webapi): Don't allow adding cardinalities to a class if it's used in data.

* refactor (webapi): Remove redunant response schema argument.

* feature (webapi): Change a class's cardinalities.

* feature (webapi): Delete a class or property.

* fix (webapi): Fix #157.

* fix (webapi): Check for duplicate IRIs and cyclical inheritance hierarchies.

* test (webapi): Don't allow creating a property with a knora-api:objectType of xsd:string.

* test (webapi): Turn off extra debugging output in test.

* docs (webapi): Document API v2 ontology routes.

* docs (webapi): Mention consistency requirement for ontology update API.

* fix (webapi): Don't modify a class's cardinalities if it has a subclass.

- Clarify consistency rules in ontology API doc.
- Test edit conflict prevention.

* test (webapi): Fix search test after the addition of a BlueThing for another test.

* docs (webapi): Clarify creation of entity names.

* test (webapi): Do some of the review tasks for #707.

* feature (webapi): More review tasks.

* feature (webapi): Add knora-api:isValueClass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing code or new feature
Projects
None yet
Development

No branches or pull requests

2 participants