Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update design docs #1066

Merged
merged 29 commits into from
Dec 6, 2018
Merged

Update design docs #1066

merged 29 commits into from
Dec 6, 2018

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Nov 20, 2018 •
edited
Loading

  • Refactor design docs to separate:
    • General design principles.
    • API v1 design.
    • API v2 design.
    • Admin API design.
  • Add API v2 design docs.
  • Update out-of-date docs where I can.

Resolves #1052.

@benjamingeer benjamingeer mentioned this pull request Nov 20, 2018
Open
@benjamingeer benjamingeer requested a review from subotic November 28, 2018 11:24
Benjamin Geer added 2 commits November 28, 2018 13:53
Merge branch 'develop' into wip/refactor-design-docs
ae2661c 
# Conflicts:
#	docs/src/paradox/05-internals/design/api-v2/index.md
#	docs/src/paradox/05-internals/design/api-v2/overview.md
#	docs/src/paradox/05-internals/design/index.md
#	webapi/src/main/scala/org/knora/webapi/messages/v2/responder/ontologymessages/KnoraApiV2WithValueObjectsTransformationRules.scala
#	webapi/src/main/scala/org/knora/webapi/messages/v2/responder/valuemessages/ValueMessagesV2.scala
docs (README): API v2 is now in beta.
e95f55c
subotic
subotic approved these changes Dec 5, 2018
View reviewed changes
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :-)

@benjamingeer benjamingeer merged commit 3a02d6f into develop Dec 6, 2018
@benjamingeer benjamingeer deleted the wip/refactor-design-docs branch December 6, 2018 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjamingeer @subotic