Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leibniz ontology #1326

Merged
merged 8 commits into from
Jun 5, 2019
Merged

Leibniz ontology #1326

merged 8 commits into from
Jun 5, 2019

Conversation

SepidehAlassi
Copy link
Contributor

@SepidehAlassi SepidehAlassi commented May 21, 2019 •
edited
Loading

  • adds ontology for BEOL-Leibniz connection

@SepidehAlassi SepidehAlassi mentioned this pull request May 21, 2019
Merged
@SepidehAlassi SepidehAlassi changed the title refactor beol ontologies Leibniz ontology May 24, 2019
@SepidehAlassi
Copy link
Contributor Author

@tobiasschweizer for the next import this PR is needed.

@tobiasschweizer
Copy link
Contributor

@SepidehAlassi So this PR just adds the new ontology for Leibniz?

@SepidehAlassi
Copy link
Contributor Author

@tobiasschweizer yes

@SepidehAlassi
Copy link
Contributor Author

@tobiasschweizer I wanted to do the refactoring of the ontologies in this branch, but realised that would need some changes also in GUI which would take long. So for now, it is better to first import Leibniz data also to beol server, and take care of refactoring later.

@tobiasschweizer
Copy link
Contributor

got it, thanks for the clarification

tobiasschweizer
tobiasschweizer approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I need this for the updated data, so let's merge it.

@SepidehAlassi
Copy link
Contributor Author

@tobiasschweizer yes, you need this for the data on the switchdrive
Thanks for checking this PR, As soon as travis is done with the checks I will merge this.

@tobiasschweizer
Copy link
Contributor

Thanks. I will also convert the data according to #1322 and put the converted data back on switchdrive as a separate file.

@tobiasschweizer
Copy link
Contributor

@SepidehAlassi I think your are good to merge!

@SepidehAlassi SepidehAlassi merged commit 56e311d into develop Jun 5, 2019
@SepidehAlassi SepidehAlassi deleted the wip/beol_OntoRefactor branch June 5, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SepidehAlassi @tobiasschweizer