feat(api-v2): No custom permissions higher than defaults #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r permission than default.
|
This pull request has been mentioned on Discuss DaSCH. There might be relevant details there: |
|
@subotic Do you think this is OK now? |
added 5 commits
June 5, 2019 10:02
# Conflicts: # webapi/src/main/scala/org/knora/webapi/responders/v2/ValuesResponderV2.scala # webapi/src/test/scala/org/knora/webapi/responders/v2/ValuesResponderV2Spec.scala
|
@subotic Would you have a minute to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that when a user creates a resource/value, they can't provide custom permissions to give themselves a higher permission on the resource/value than they would get from its default permissions, unless they're a system admin or an admin of the containing project.
Resolves #1334.