Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): Fix port in use error #1356

Merged
merged 2 commits into from
Jun 20, 2019
Merged

fix(build): Fix port in use error #1356

merged 2 commits into from
Jun 20, 2019

Conversation

benjamingeer
Copy link

Fixes #1355.

@benjamingeer benjamingeer requested a review from subotic June 19, 2019 11:25
subotic
subotic requested changes Jun 20, 2019
View reviewed changes
KnoraBuild.sbt Outdated Show resolved Hide resolved
benjamingeer pushed a commit that referenced this pull request Jun 20, 2019
fix(build): Fix build as per #1356.
ff5265d
subotic
subotic approved these changes Jun 20, 2019
View reviewed changes
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. If it works for you then this is great :-)

@benjamingeer benjamingeer merged commit 22f6927 into develop Jun 20, 2019
@benjamingeer benjamingeer deleted the fix/1355-port-in-use branch June 20, 2019 14:23
@benjamingeer
Copy link
Author

Thanks for the review!

@benjamingeer benjamingeer mentioned this pull request Jun 20, 2019
Open
benjamingeer pushed a commit that referenced this pull request Jul 9, 2019
feat: Generate client API code, part 1 (#1259)
969f227 
* feature (InputOntologyV2): Parse a Knora ontology response for generation of client code.

* feature (api-v2): Add some infrastructure for client API class generation.

* feat: Start adding client-code generator front end implementation.

* feat: Generate client code for json2typescript (ongoing).

* feat: Generate client code from ontologies (ongoing).

* feat: Generate client API code from ontologies (ongoing).

* feat(api-v2): Backport improvements to ontology response parsing from #1297.

* fix(client-code-generation): Fix compile errors, add comments.

* feat(client): Add definition of users endpoint.

* feat(clientapi): Add documentation strings to endpoint definition.

- Move extra API classes to external schema of admin ontology.

* feat(clientapi): Collect the IRIs of class definitions used in a client API definition.

* feat(clientapi): Generate client code for whole APIs (ongoing).

* feat(clientapi): Generate client code for whole APIs (ongoing).

* feat(clientapi): Generate endpoints (ongoing).

* feat(clientapi): Generate endpoint (ongoing).

* feat(clientapi): Generate endpoint (ongoing).

* feat(clientapi): Generate interfaces.

* style(clientapi): Add comments.

* fix(build): Fix build as per #1356.

* feat(clientapi): Make DSL more concise.

* feat(clientapi): Simplify DSL.

* feat(clientapi): Simplify booleans.

* feat(clientapi): Improve DSL.

* feat(clientapi): Correct User class in external schema.

- Fix lots of bugs.

* test(knora-ontologies): Rename knoraProject -> Project in external schema.

* feat(clientapi): Correct Group and Project classes in external schema.

- Improve formatting of generated code.

* test: Allow InstanceChecker to get knora-admin definitions.

* feat(clientapi): Add property and class descriptions to generated code.

* test(InstanceChecker): Fix test data.

* feat(clientapi): Generate knora-api-connection.ts.

* feat(clientapi): Implement more admin client API functions.

* feat(clientapi): Implement the rest of the users endpoint.

* docs(clientapi): Add docs.

- Start implementing permissions endpoint.
- Support optional function parameters.
- Support URL parameters.

* feat(clientapi): Replace the command-line program with a route.

* feat(clientapi): Add permissions route.

* style(clientapi): Add comments.

* fix(clientapi): Fix compile error.

* refactor(clientapi): Move TypeScript templates into a subdirectory.

* style(clientapi): Set the order of endpoints in the API definition.

* style(clientapi): Rename parameter.

* feat(clientapi): Add groups endpoint.

- Generate URL query parameters.
- Fix empty URL paths.
- Support type conversion in function calls.
- Support integer literals.

* feat(clientapi): Implement some of the projects endpoint.

* feat(clientapi): Implement the rest of the projects endpoint.

* fix(clientapi): Fix path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't run more than one program at the same time from SBT console
2 participants
@benjamingeer @subotic