Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Convert Knora base ontology doc to RST. #289

Merged
merged 3 commits into from
Oct 24, 2016

Conversation

benjamingeer
Copy link

This converts the LaTeX file documenting the Knora base ontology to reStructuredText, and integrates it with the rest of the Knora documentation.

@benjamingeer benjamingeer added the enhancement improve existing code or new feature label Oct 21, 2016
@benjamingeer benjamingeer added this to the Beta Release milestone Oct 21, 2016
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Finally we can get rid of the pdf in our repo.

How did you do the conversion? pandoc?

@@ -31,6 +31,7 @@
# ones.
extensions = [
'sphinx.ext.todo',
'sphinx.ext.graphviz'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graphviz has to be installed on the system first (e.g. brew install graphviz for Mac OS X or sudo apt-get install graphviz for Debian-based Linux distros).

Could please add that to the installation instructions in the docs/README? Or will those requirements be met otherwise by running another program that takes conf.py as its input?

However, their website http://www.sphinx-doc.org/en/stable/ext/graphviz.html says:

Since this setting is not portable from system to system, it is normally not useful to set it in conf.py

@@ -31,6 +31,7 @@
# ones.
extensions = [
'sphinx.ext.todo',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the TODOs (including their reference to open issues)?

Resource Description Framework (RDF)
------------------------------------

Knora uses a hierarchy of ontologies based on the Resource Description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to explain what Knora stands for: Knowledge Organization, Representation, and Annotation, http://knora.org

But maybe since this is not a standalone document anymore, we can assume that the reader has learned about that in another section.

any substring in the text by giving its start and end positions. [#]_
For example, suppose we have the following text:

This sentence has overlapping visual attributes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence should be formatted (see
screen shot 2016-10-24 at 09 19 11
)

@benjamingeer
Copy link
Author

I did the initial conversion with pandoc, then converted the diagrams and references manually.

What happened to the TODOs (including their reference to open issues)?

I disabled the Sphinx TODO plugin several months ago because it makes a mess on the front page of the documentation (for each TODO, it shows the absolute path to the original file on the computer where the documentation was generated).

There were just two TODOs left in knora-base.tex:

graphviz has to be installed on the system first

I'll add something about that to the README.

We used to explain what Knora stands for: Knowledge Organization, Representation, and Annotation, http://knora.org

But maybe since this is not a standalone document anymore, we can assume that the reader has learned about that in another section.

Yes, it's already explained in what-is-knora.rst.

This sentence should be formatted

Unfortunately that's not possible in RST, because inline markup cannot be nested. That's why I changed the following sentence to explain the intended effect.

@tobiasschweizer
Copy link
Contributor

tobiasschweizer commented Oct 24, 2016

Ok, I fixed the formatting using raw HTML. http://docutils.sourceforge.net/docs/ref/rst/directives.html#raw-data-pass-through

Maybe this causes problems for other output formats using LaTeX.

@tobiasschweizer
Copy link
Contributor

tobiasschweizer commented Oct 24, 2016

In general, the conversion to LaTeX seems to have some problems (TOC only given for the ontology documentation, but with missing page numbers; problems with images; problems with Unicode chars).

This is not new though. RST to LaTeX never passed through properly.

@benjamingeer
Copy link
Author

Maybe we should just write all the documentation directly in HTML. :)

@benjamingeer
Copy link
Author

I added issue #293 for ExternalResource and ExternalResValue.

@tobiasschweizer
Copy link
Contributor

möörge

@benjamingeer benjamingeer merged commit 6ac44f8 into develop Oct 24, 2016
@benjamingeer benjamingeer deleted the wip/knora-base-rst branch October 24, 2016 13:03
SepidehAlassi added a commit that referenced this pull request Oct 31, 2016
…ip/beol

* 'develop' of https://github.com/dhlab-basel/Knora:
  Update README.md
  test (webapi): add E2E testing (#244)
  BEOL and bibliography ontologies (#283)
  refactor (webapi): migrate spray to akka http (#273)
  fix (sipi error message): display the error message returned by SIPI (#287)
  Add support for editing labels and value comments (#261)
  docs: Convert Knora base ontology doc to RST. (#289)
  relative paths (#288)
  removing relative paths to icons in css file: it doesn't survive an front apache proxy like: (#191)
  adding css and fonts used in the js/jquery.editvalue.js (#180)
  docs: Add remark about pyvenv for anaconda users on mac and linux (#264)
  add internal link to doc/readme (#278)
  docs (extended search): add missing explanations for LIKE and !LIKE (#279)
  Upgrade the built-in Fuseki to version 2.4.0 (#268)

# Conflicts:
#	knora-ontologies/knora-base.ttl
#	webapi/src/test/scala/org/knora/webapi/responders/v1/OntologyResponderV1Spec.scala
@benjamingeer benjamingeer mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants