Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a compound resource without images #358

Merged
merged 5 commits into from
Jan 18, 2017

Conversation

benjamingeer
Copy link

If a compound resource lacks images (like "excluded alpha" in the anything test data), display it with a default "no image" image.

Fixes #334.

@tobiasschweizer
Copy link
Contributor

Could you add a browser test for this?

@benjamingeer
Copy link
Author

@benjamingeer
Copy link
Author

Done, is this OK?

@benjamingeer benjamingeer merged commit 5eacd0c into develop Jan 18, 2017
@benjamingeer benjamingeer deleted the wip/compound-resource-without-images branch January 18, 2017 11:53
SepidehAlassi added a commit that referenced this pull request Jan 24, 2017
* develop: (22 commits)
  fix (bug) default permissions removed
  feature (bibliography) resource Edition is added
  Display a compound resource without images (#358)
  User, Project, and Group Management (#299)
  fix (webapi): Handle request for nonexistent resource class. (#377)
  fix (biblio-onto) a bug in ontology is fixed
  fix (webapi): Fix permission checking on link values (#367)
  fix (limit incoming references): limit the number of incoming references (#365)
  fix (ontology responder): ignore knora-base:resourceProperty in ontology responder for property definitions (#362)
  fix (bibliography) the bug with comments of resources is fixed
  fix (webapi): sipi integration (#340)
  Don't redundantly traverse cycles in graph data query (#350)
  Optimise queries for GraphDB and refactor query optimisation (#336)
  Document deleteComment (#337)
  feature (beol), person is moved from Knora-base to bell ontology, comment is added to biblio resources.
  feature [bibliography] added the collection to books too
  feature [bibliography] the resources editor and organization are added
  commit [feature] the collectionArticle, journal Issue, and JournalArticle added
  feature (bibliography) subtitle is added to publication
  feature (bibliography): translation labels in it and fr, added doi for publication
  ...
@benjamingeer benjamingeer mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants