-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display a compound resource without images #358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you add a browser test for this? |
See example no. 3: |
Done, is this OK? |
SepidehAlassi
added a commit
that referenced
this pull request
Jan 24, 2017
* develop: (22 commits) fix (bug) default permissions removed feature (bibliography) resource Edition is added Display a compound resource without images (#358) User, Project, and Group Management (#299) fix (webapi): Handle request for nonexistent resource class. (#377) fix (biblio-onto) a bug in ontology is fixed fix (webapi): Fix permission checking on link values (#367) fix (limit incoming references): limit the number of incoming references (#365) fix (ontology responder): ignore knora-base:resourceProperty in ontology responder for property definitions (#362) fix (bibliography) the bug with comments of resources is fixed fix (webapi): sipi integration (#340) Don't redundantly traverse cycles in graph data query (#350) Optimise queries for GraphDB and refactor query optimisation (#336) Document deleteComment (#337) feature (beol), person is moved from Knora-base to bell ontology, comment is added to biblio resources. feature [bibliography] added the collection to books too feature [bibliography] the resources editor and organization are added commit [feature] the collectionArticle, journal Issue, and JournalArticle added feature (bibliography) subtitle is added to publication feature (bibliography): translation labels in it and fr, added doi for publication ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a compound resource lacks images (like "excluded alpha" in the
anything
test data), display it with a default "no image" image.Fixes #334.