Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies in incunabula-demo-data.ttl. #407

Merged
merged 3 commits into from
Feb 6, 2017

Conversation

benjamingeer
Copy link

Fixes #405.

  • Ran incunabula-demo-data.ttl through TransformData -t all.
  • Added missing valueHasCreationDate.
  • Added text to fix empty strings.
  • There were many references to sidebands, but no actual sidebands. Removed all references to sidebands.

@tobiasschweizer
Copy link
Contributor

incunabula-demo-data now passes consistency checking.
However, it is not used (loaded) anywhere. So I wonder why we have it.

@subotic
Copy link
Collaborator

subotic commented Feb 6, 2017

We created it at the time when we published Knora on Github, so that a potential user would have some demo data that would load in a shorter time, then the full incunabula data.

IMHO we can remove this. We have enough ttl files that we need to maintain. We still have ``images-demo.ttl` which could be used for a quick test.

I don't know if Lausanne is using this.

Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it passes consistency checking now so it can be merged (even though we might remove it later :-))

@mrivoal
Copy link

mrivoal commented Feb 6, 2017

No, we don't use it.

I loaded it the last time because I got lost in the .ttl files avaiblable. I wanted to run some tests but I could have done it with incunabula-data.ttl.

@benjamingeer
Copy link
Author

@tobiasschweizer
Copy link
Contributor

Right! Ok, it can be merged then.

@loicjaouen
Copy link
Contributor

i don't see a reference to incunabula-demo-data.ttl but incunabula-data.ttl.

@tobiasschweizer
Copy link
Contributor

store-module.rst:

            {
                path = "_test_data/demo_data/incunabula-demo-data.ttl"
                name = "http://www.knora.org/data/incunabula"
            }

@benjamingeer
Copy link
Author

If you're all happy for the huge incunabula-data.ttl to be used in the docs, I'm happy to delete incunabula-demo-data.ttl. One less thing to maintain.

@loicjaouen
Copy link
Contributor

loicjaouen commented Feb 6, 2017

we are not particularly happy with the huge file, but we got side-tracked by the outdated small one.

It is now in sync, fine, let's keep it.
But there is no automated ways to check it, so maintaining it will be difficult and chances of lags are high.

@benjamingeer benjamingeer merged commit e59fe14 into develop Feb 6, 2017
@benjamingeer benjamingeer deleted the wip/fix-incunabula-demo branch February 6, 2017 15:30
@benjamingeer benjamingeer mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incunabula-demo-data.ttl doesn't pass the consistency checking
6 participants