Correctly use and display user's name and projects #435
Conversation
benjamingeer
changed the title
benjamingeer
changed the title
…UserProfileV1 and UserDataV1
# Conflicts: # webapi/src/main/scala/org/knora/webapi/util/PermissionUtilV1.scala
| /** | ||
| * The current user's data | ||
| */ | ||
| userdata:userdata; |
There was a problem hiding this comment.
Did you also mean to remove the whole interface userdata?
There was a problem hiding this comment.
Now I've moved it to sessionResponseFormats.ts, which has the whole login response format. There's a sample in sampleLoginResponse.ts.
|
I found a nice service that generates TypeScript interfaces from sample data: http://json2ts.com/ |
- Remove project basepath, which is not used.
|
OK I changed |
| /** | ||
| * The IRIs of the groups that the user belongs to. | ||
| */ | ||
| groups: Array<string>; |
There was a problem hiding this comment.
You could use the KnoraIri pseudo type here just to make it more clear that is is an Knora IRI: https://github.com/dhlab-basel/Knora/blob/wip/salsah-username/salsah/src/typescript_interfaces/basicMessageComponents.ts#L245
|
go on, genius |
User-visible changes in SALSAH:
Internal changes:
userProfile, instead of just the project IRIs.userProfileon login, rather than justuserData, and store it.userDatafrom API responses, since SALSAH no longer needs it.Note: To get the GUI tests to work, I had to change them so the user is logged in at the beginning of each test, and logged out at the end of each test. Otherwise reloading the page seemed to make SALSAH forget that the user was logged in. I had this problem only with Selenium, not in real life.
Fixes #118.
Fixes #415.