Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Knora-Sipi integration tests #445

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Clean up Knora-Sipi integration tests #445

merged 2 commits into from
Mar 2, 2017

Conversation

benjamingeer
Copy link

I forgot to do this cleanup in #414, so here's another PR for it.

@benjamingeer benjamingeer added the enhancement improve existing code or new feature label Mar 2, 2017
@benjamingeer benjamingeer added this to the Beta Release milestone Mar 2, 2017
tobiasschweizer
tobiasschweizer approved these changes Mar 2, 2017
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding again.
I especially like how you increased the duration.

@benjamingeer benjamingeer merged commit 7ba1d38 into develop Mar 2, 2017
@benjamingeer benjamingeer deleted the wip/sipi-integration-tests-cleanup branch March 2, 2017 17:00
@benjamingeer benjamingeer mentioned this pull request Jul 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

Assignees

@tobiasschweizer tobiasschweizer

Labels
enhancement improve existing code or new feature
Projects
None yet
Milestone
Beta Release
Development

Successfully merging this pull request may close these issues.
3 participants
@benjamingeer @tobiasschweizer @kilchenmann