Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate dereferenceable IRIs using the rdfh.ch hostname #453

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Generate dereferenceable IRIs using the rdfh.ch hostname #453

merged 1 commit into from
Mar 15, 2017

Conversation

benjamingeer
Copy link

This changes the function KnoraIdUtil.makeRandomResourceIri():

  • Include the project's shortname (which will be a unique ID) in the IRI.
  • Use rdfh.ch as the IRI domain name. This will point to a server that redirects requests to Knora API servers depending on the project ID in the IRI.

I also removed some unused methods, and clarified and reformatted some code.

feature (webapi): Generate dereferenceable IRIs using the rdfh.ch hos…
aacadf7 
…tname.

- Clarify and refactor some other code.
@benjamingeer benjamingeer added enhancement improve existing code or new feature ready-for-review labels Mar 15, 2017
@benjamingeer benjamingeer added this to the Beta Release milestone Mar 15, 2017
@benjamingeer benjamingeer requested review from subotic and tobiasschweizer and removed request for subotic March 15, 2017 10:44
tobiasschweizer
tobiasschweizer approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

I created a resource with values and resource and value Iris look correct.

@benjamingeer benjamingeer merged commit e5d72e8 into develop Mar 15, 2017
@tobiasschweizer
Copy link
Contributor

Can this branch be deleted?

@benjamingeer benjamingeer deleted the wip/deref-iris branch March 16, 2017 13:12
@benjamingeer benjamingeer mentioned this pull request Jul 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

Assignees

@benjamingeer benjamingeer

@tobiasschweizer tobiasschweizer

Labels
enhancement improve existing code or new feature
Projects
None yet
Milestone
Beta Release
Development

Successfully merging this pull request may close these issues.
4 participants
@benjamingeer @tobiasschweizer @subotic @kilchenmann