Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove knora-dc #730

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Remove knora-dc #730

merged 2 commits into from
Feb 12, 2018

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Feb 9, 2018

This removes the knora-dc ontology, which is no longer needed now that API v2 can use the real dc or dcterms.

Ontologies in webapi/_test_data/ontologies that used knora-dc are changed to use dcterms.

Resolves #729.

@benjamingeer benjamingeer requested review from tobiasschweizer and subotic and removed request for tobiasschweizer February 9, 2018 17:06
@subotic subotic assigned benjamingeer and unassigned subotic Feb 9, 2018
@subotic subotic added the enhancement improve existing code or new feature label Feb 9, 2018
@subotic subotic added this to the v1.2.0 milestone Feb 9, 2018
@tobiasschweizer
Copy link
Contributor

Maybe you could add a test like the following:

PREFIX knora-api: <http://api.knora.org/ontology/knora-api/simple/v2#>
    PREFIX dcterms: <http://purl.org/dc/terms/> 
    
    CONSTRUCT {
        ?book knora-api:isMainResource true .
        
        ?book dcterms:title ?title .
        
    } WHERE {
        ?book a knora-api:Resource .
        
        ?book dcterms:title ?title .
        
        dcterms:title knora-api:objectType xsd:string .

        ?title a xsd:string .
        
        FILTER(?title = 'Zeitglöcklein des Lebens und Leidens Christi')
        
    } OFFSET 0

->

{
  "@type" : "schema:ItemList",
  "schema:itemListElement" : [ {
    "@id" : "http://data.knora.org/c5058f3a",
    "@type" : "incunabula:book",
    "incunabula:title" : {
      "@id" : "http://data.knora.org/c5058f3a/values/c3295339",
      "@type" : "knora-api:TextValue",
      "knora-api:valueAsString" : "Zeitglöcklein des Lebens und Leidens Christi"
    },
    "schema:name" : "Zeitglöcklein des Lebens und Leidens Christi"
  }, {
    "@id" : "http://data.knora.org/ff17e5ef9601",
    "@type" : "incunabula:book",
    "incunabula:title" : {
      "@id" : "http://data.knora.org/ff17e5ef9601/values/d9a522845006",
      "@type" : "knora-api:TextValue",
      "knora-api:valueAsString" : "Zeitglöcklein des Lebens und Leidens Christi"
    },
    "schema:name" : "Zeitglöcklein des Lebens und Leidens Christi"
  } ],
  "schema:numberOfItems" : 2,
  "@context" : {
    "rdf" : "http://www.w3.org/1999/02/22-rdf-syntax-ns#",
    "knora-api" : "http://api.knora.org/ontology/knora-api/v2#",
    "schema" : "http://schema.org/",
    "rdfs" : "http://www.w3.org/2000/01/rdf-schema#",
    "incunabula" : "http://0.0.0.0:3333/ontology/incunabula/v2#"
  }
}

Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. maybe add the test that @tobiasschweizer mentioned. thanks.

@benjamingeer
Copy link
Author

@subotic Thanks!

@benjamingeer benjamingeer merged commit 1de11fa into develop Feb 12, 2018
@benjamingeer benjamingeer deleted the wip/remove-knora-dc branch February 12, 2018 19:56
SepidehAlassi added a commit that referenced this pull request Feb 13, 2018
* develop:
  feature (webapi): admin api (part 6) (#716)
  Remove knora-dc (#730)
@benjamingeer benjamingeer mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing code or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants