Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow class with cardinalities on P and on a subproperty of P #982

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Aug 28, 2018

This prevents the problem described in #978.

  • Check for this when loading ontologies on startup.
  • Check for this when creating a class via API v2.
  • Add tests.
  • Update docs and release notes.

Fixes #978.

@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #982 into develop will increase coverage by <.01%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #982      +/-   ##
===========================================
+ Coverage    82.51%   82.52%   +<.01%     
===========================================
  Files          150      150              
  Lines        17054    17069      +15     
  Branches      1613     1629      +16     
===========================================
+ Hits         14072    14086      +14     
- Misses        2982     2983       +1
Flag Coverage Δ
#integration 46.15% <54.54%> (ø) ⬆️
#unit_e2e 81.35% <95.45%> (+0.01%) ⬆️
Impacted Files Coverage Δ
...ora/webapi/responders/v2/OntologyResponderV2.scala 90.76% <95.45%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b12b83e...94cfd2b. Read the comment docs.

Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/V2 bug something isn't working bulk-import
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants