Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add link value prop cardinality with link prop cardinality #989

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

benjamingeer
Copy link

Fixes #988.

@lrosenth could you try this branch?

@codecov
Copy link

codecov bot commented Sep 5, 2018

Codecov Report

Merging #989 into develop will increase coverage by <.01%.
The diff coverage is 88.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #989      +/-   ##
===========================================
+ Coverage     82.3%   82.31%   +<.01%     
===========================================
  Files          153      153              
  Lines        17700    17704       +4     
  Branches      1625     1634       +9     
===========================================
+ Hits         14568    14573       +5     
+ Misses        3132     3131       -1
Flag Coverage Δ
#integration 44.95% <0%> (-0.02%) ⬇️
#unit_e2e 81.19% <88.46%> (ø) ⬆️
Impacted Files Coverage Δ
...ora/webapi/responders/v2/OntologyResponderV2.scala 91% <88.46%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2cba92...b054150. Read the comment docs.

Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM :-)

@benjamingeer
Copy link
Author

Thanks for the quick review! :)

@benjamingeer benjamingeer merged commit 35a2bff into develop Sep 5, 2018
@benjamingeer benjamingeer deleted the fix/988-link-prop-cardinalities branch September 5, 2018 13:58
@benjamingeer benjamingeer mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants