fix: paging of incoming links works again #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derschnee68
changed the title
irmastnt
requested changes
Feb 13, 2025
libs/vre/resource-editor/resource-properties/src/lib/incoming-links-property.component.ts
Outdated
Show resolved
Hide resolved
libs/vre/resource-editor/resource-properties/src/lib/incoming-links-property.component.ts
Outdated
Show resolved
Hide resolved
mpro7
reviewed
Feb 13, 2025
libs/vre/resource-editor/resource-properties/src/lib/incoming-links-property.component.ts
Outdated
Show resolved
Hide resolved
…ng-of-incoming-links-is-broken
mpro7
reviewed
Feb 13, 2025
libs/vre/resource-editor/resource-properties/src/lib/standoff-links-property.component.ts
Outdated
Show resolved
Hide resolved
domsteinbach
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
We should change it so the results of the first index are piped to be displayed even if there are more pages/results. And we should only load the index + 1 page additionally. Loading all possible pages is too expensive.
-> https://linear.app/dasch/issue/DEV-4594/enhance-incoming-links
libs/vre/resource-editor/resource-properties/src/lib/properties-display.component.ts
Show resolved
Hide resolved
domsteinbach
requested changes
Feb 17, 2025
libs/vre/resource-editor/resource-properties/src/lib/incoming-links-property.component.ts
Outdated
Show resolved
Hide resolved
libs/vre/resource-editor/resource-properties/src/lib/incoming-links-property.component.ts
Outdated
Show resolved
Hide resolved
domsteinbach
approved these changes
Feb 17, 2025
…ing-links-is-broken' into feature/dev-4587-paging-of-incoming-links-is-broken
derschnee68
deleted the
feature/dev-4587-paging-of-incoming-links-is-broken
branch
irmastnt
added a commit
that referenced
this pull request
Feb 18, 2025
…ember-cannot-create-link-objects * main: chore(deps-dev): bump @types/jasmine from 4.6.4 to 4.6.5 in the jasmine-karma-deps group (#2118) chore(main): release 11.26.0 (#2098) fix: does not display empty rows (#2122) fix: json parsing issue in en.json (#2117) fix: paging of incoming links works again (#2108)
irmastnt
added a commit
that referenced
this pull request
Feb 18, 2025
…the-resources-found-through * main: chore(deps-dev): bump @types/jasmine from 4.6.4 to 4.6.5 in the jasmine-karma-deps group (#2118) chore(main): release 11.26.0 (#2098) fix: does not display empty rows (#2122) fix: json parsing issue in en.json (#2117) fix: paging of incoming links works again (#2108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-4587, DEV-4586