fix: paging of incoming links works again #2108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derschnee68
changed the title
irmastnt
requested changes
Feb 13, 2025
| @Component({ | ||
| selector: 'app-incoming-links-property', | ||
| template: ` <app-property-row | ||
| tooltip="Indicates that this resource is referred to by another resource" |
| export class IncomingLinksPropertyComponent implements OnChanges { | ||
| @Input({ required: true }) resource!: DspResource; | ||
|
|
||
| get myLinks() { |
There was a problem hiding this comment.
consider renaming it to more meaningful name
mpro7
reviewed
Feb 13, 2025
| @Component({ | ||
| selector: 'app-incoming-links-property', | ||
| template: ` <app-property-row | ||
| tooltip="Indicates that this resource is referred to by another resource" |
There was a problem hiding this comment.
Suggested change
| tooltip="Indicates that this resource is referred to by another resource" | |
| tooltip="Indicates this resource is referred by another resource." |
…ng-of-incoming-links-is-broken
mpro7
reviewed
Feb 13, 2025
| @Component({ | ||
| selector: 'app-standoff-links-property', | ||
| template: ` <app-property-row | ||
| tooltip=" Represent a link in standoff markup from one resource to another" |
There was a problem hiding this comment.
Suggested change
| tooltip=" Represent a link in standoff markup from one resource to another" | |
| tooltip=" Represents a standoff markup link between two resources." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-