-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin): Add custom converters for collection types #99
Conversation
@benjamingeer This looks good, thank you! I will check this PR with @kilchenmann today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to use the builded package of this branch in the knora-ui or in the knora-api-js-lib-test app, but I got on both branches the following errors:
ERROR in node_modules/@knora/api/src/api/endpoint.d.ts(18,9): error TS1086: An accessor cannot be declared in an ambient context.
node_modules/@knora/api/src/api/endpoint.d.ts(22,9): error TS1086: An accessor cannot be declared in an ambient context.
node_modules/@knora/api/src/knora-api-config.d.ts(18,9): error TS1086: An accessor cannot be declared in an ambient context.
The error says it's because of these lines:
/**
* The session token
*/
get jsonWebToken(): string;
/**
* The session token
*/
set jsonWebToken(value: string);
I cleaned everything and I'm not sure if it's an issue from this branch or from somewhere else.
I have spotted this behavior as well in dasch-swiss/knora-api-js-lib-test#21 when the e2e test ran on travis. I could reproduce this locally with Please try the following:
In @knora/api we use Then install the local package in your app with |
Thanks @tobiasschweizer. It's seems to be an issue with the dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks
Thanks @tobiasschweizer and @kilchenmann for your help with this! |
This PR adds implementations of
JsonCustomConvert
to handle the collections that are objects of the propertiesadministrativePermissionsPerProject
andgroupsPerProject
in the classPermissionsData
.Resolves #92.
Resolves #97.
Closes #98.
Needs dasch-swiss/dsp-api#1505.