feat(injector): External resource detection for OpenTelemetry-instrumented applications #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well I honestly did not expect the PR to go green on the first attempt. |
mmanciop
commented
Dec 2, 2024
mmanciop
changed the title
basti1302
force-pushed
the
k8s-discovery
branch
from
793b6fe to
3342c45
Compare
basti1302
reviewed
Dec 16, 2024
images/instrumentation/injector/test/scripts/run-tests-within-container.sh
Outdated
Show resolved
Hide resolved
Also: - rename vars for cached modified values - document why we don't need to percent-escape OTEL_RESOURCE_ATTRIBUTES values - improve injector test script
basti1302
force-pushed
the
k8s-discovery
branch
2 times, most recently
from
7d8ccc4 to
3072fe0
Compare
basti1302
force-pushed
the
k8s-discovery
branch
2 times, most recently
from
c64786f to
29c1cfe
Compare
|
basti1302
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.