various test fixes #231
Merged
various test fixes #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
changed the title
joschi
approved these changes
Jan 13, 2025
As long as the workload modifier writes this env var, the simluated modified workloads used in tests should include it as well.
After 088b15c, the script for generating a Dockerfile for the locally running injector tests required a small fix. (Notably this was not an issue for CI because there we download the instrumentation actual image produced by an earlier build step and copy the injector binary from there.)
* extract repetitive docker run command parts * shorten test output, only print docker build/docker run output if build or test fails (this was in place earlier and was removed with 088b15c, this commit restores the previous state)
basti1302
force-pushed
the
minor-follow-up-tweaks
branch
from
f9c5f38 to
ed10fa6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
basti1302
force-pushed
the
minor-follow-up-tweaks
branch
2 times, most recently
from
acdcc40 to
4414820
Compare
basti1302
force-pushed
the
minor-follow-up-tweaks
branch
from
4414820 to
b5b6616
Compare
Also: * speed up webhook e2e tests by not re-deploying the Dash0 monitoring resource for every test
basti1302
force-pushed
the
minor-follow-up-tweaks
branch
from
b5b6616 to
bb6edd9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as the workload modifier writes this env var, the simluated modified workloads used in tests should include it as well.