Adapt tests to OTP26 (#131)

dashbitco · Aug 27, 2023 · 3227bf0 · 3227bf0
1 parent f9f13e2
commit 3227bf0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 16 deletions.
diff --git a/test/allocator_test.exs b/test/allocator_test.exs
@@ -70,6 +70,7 @@ defmodule BroadwayKafka.AllocatorTest do
         entry <- entries,
         do: ^partition = fetch!(name, entry)
 
-    map
+    # ensure the value list is sorted, to be able to reliably assert
+    Map.new(map, fn {k, v} -> {k, Enum.sort(v)} end)
   end
 end
diff --git a/test/producer_test.exs b/test/producer_test.exs
@@ -173,13 +173,12 @@ defmodule BroadwayKafka.ProducerTest do
   test "do not allow users to set :partition_by for processors" do
     Process.flag(:trap_exit, true)
 
-    Broadway.start_link(Forwarder,
-      name: new_unique_name(),
-      producer: [module: {BroadwayKafka.Producer, []}],
-      processors: [default: [partition_by: fn msg -> msg.data end]]
-    )
-
-    assert_receive {:EXIT, _, {%ArgumentError{message: message}, _}}
+    {:error, {%ArgumentError{message: message}, _}} =
+      Broadway.start_link(Forwarder,
+        name: new_unique_name(),
+        producer: [module: {BroadwayKafka.Producer, []}],
+        processors: [default: [partition_by: fn msg -> msg.data end]]
+      )
 
     assert message ==
              "cannot set option :partition_by for processors :default. " <>
@@ -189,14 +188,13 @@ defmodule BroadwayKafka.ProducerTest do
   test "do not allow users to set :partition_by for batchers" do
     Process.flag(:trap_exit, true)
 
-    Broadway.start_link(Forwarder,
-      name: new_unique_name(),
-      producer: [module: {BroadwayKafka.Producer, []}],
-      processors: [default: []],
-      batchers: [default: [partition_by: fn msg -> msg.data end]]
-    )
-
-    assert_receive {:EXIT, _, {%ArgumentError{message: message}, _}}
+    {:error, {%ArgumentError{message: message}, _}} =
+      Broadway.start_link(Forwarder,
+        name: new_unique_name(),
+        producer: [module: {BroadwayKafka.Producer, []}],
+        processors: [default: []],
+        batchers: [default: [partition_by: fn msg -> msg.data end]]
+      )
 
     assert message ==
              "cannot set option :partition_by for batchers :default. " <>