backport: partial Merge bitcoin-core/gui#96: Slight improve create wallet dialog #5894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bitcoin has also a brand-new design for Create Wallet dialog but it seems as no one ever implemented it yet: bitcoin-core/gui#77
|
thephez
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Is enabling "Disable Private Keys" supposed to also enable "Make Blank Wallet"? v20 doesn't do that, but this PR does. I think it makes sense because it's necessary to use RPC to add stuff to a watch-only wallet.
I do like that proposed bitcoin screen better since it actually explains things more clearly.
It is expected change
That's a good one indeed but they don't have any implementation for it yet and not much discussion since proposed in 2020-2022 |
PastaPastaPasta
approved these changes
Feb 24, 2024
…llet dialog It fixes strange behaviour of enable/disable checkboxes and checking/unchecking them
PastaPastaPasta
force-pushed
the
fix-create-dialog
branch
from
800c230 to
a50f20d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
It fixes strange behaviour of enable/disable checkboxes and checking/unchecking them
kudos to thephez to found an issue.
What was done?
Partial backport bitcoin-core/gui#96
How Has This Been Tested?
Build & run
dash-qtBreaking Changes
No actual code changed for creating wallet, only UI for it
Checklist: