perf(dpp): optimize js binding size

dashpay · Dec 17, 2024 · 9b71435 · 9b71435
1 parent 494054a
commit 9b71435
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 6 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -73,6 +73,13 @@ jobs:
         run: cargo binstall [email protected]
         if: ${{ steps.check-artifact.outputs.exists != 'true' }}
 
+      - name: Install Binaryen
+        run: |
+          wget https://github.com/WebAssembly/binaryen/releases/download/version_109/binaryen-version_121-x86_64-linux.tar.gz
+          tar -xzf binaryen-version_121-x86_64-linux.tar.gz
+          sudo cp -r binaryen-version_121/* /usr/local/
+        if: ${{ steps.check-artifact.outputs.exists != 'true' }}
+
       - name: Build packages
         run: yarn build
         env:

diff --git a/.github/workflows/tests-build-js.yml b/.github/workflows/tests-build-js.yml
@@ -53,6 +53,13 @@ jobs:
         run: cargo binstall [email protected]
         if: ${{ steps.check-artifact.outputs.exists != 'true' }}
 
+      - name: Install Binaryen
+        run: |
+          wget https://github.com/WebAssembly/binaryen/releases/download/version_109/binaryen-version_121-x86_64-linux.tar.gz
+          tar -xzf binaryen-version_121-x86_64-linux.tar.gz
+          sudo cp -r binaryen-version_121/* /usr/local/
+        if: ${{ steps.check-artifact.outputs.exists != 'true' }}
+
       - name: Build JS packages
         run: yarn build
         if: ${{ steps.check-artifact.outputs.exists != 'true' }}

diff --git a/packages/wasm-dpp/Cargo.toml b/packages/wasm-dpp/Cargo.toml
@@ -54,6 +54,6 @@ async-trait = "0.1.59"
 bincode = "2.0.0-rc.3"
 [profile.release]
 lto = true
-opt-level = 's'
+opt-level = 'z'
 [package.metadata.cargo-machete]
 ignored = ["wasm-bindgen-futures"]
diff --git a/packages/wasm-dpp/scripts/build-wasm.sh b/packages/wasm-dpp/scripts/build-wasm.sh
@@ -47,8 +47,9 @@ fi
 # EMCC_CFLAGS="-s ERROR_ON_UNDEFINED_SYMBOLS=0 --no-entry" cargo build --target=wasm32-unknown-emscripten --release
 # EMCC_CFLAGS="-s ERROR_ON_UNDEFINED_SYMBOLS=0 --no-entry" wasm-bindgen --out-dir=wasm --target=web --omit-default-module-path ../../target/wasm32-unknown-emscripten/release/wasm_dpp.wasm
 
-# TODO: Must be somehow preinstalled?
-#if [ "$PROFILE" == "release" ]; then
-#  echo "Optimizing wasm using Binaryen"
-#  wasm-opt -Os "$OUTPUT_FILE" -o "$OUTPUT_FILE"
-#fi
+if command -v wasm-opt &> /dev/null; then
+  echo "Optimizing wasm using Binaryen"
+  wasm-opt -Oz "$OUTPUT_FILE" -o "$OUTPUT_FILE"
+else
+  echo "wasm-opt command not found. Skipping wasm optimization."
+fi