fix(platform)!: advanced data contract structure validation position #1763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There are a few improvements that are needed to remove the ability for attacks on the network. This is one of them.
What was done?
In this PR we removed data contract validation from check tx, and instead put it in an advanced section in block processing. If it fails we bump the identity nonce for data contract create or identity contract nonce for data contract updates.
Also bumped the min transfer amount from 1 duff to 100 duffs.
How Has This Been Tested?
Created a test that would check_tx for an invalid contract. The check_tx passes, but the block processing marks the transaction as invalid and bumps the identity nonce as expected.
Breaking Changes
Validation changes are breaking.
The min transfer amount is now 100 duffs.
Checklist:
For repository code-owners and collaborators only