Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform)!: advanced data contract structure validation position #1763

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Mar 11, 2024

Issue being fixed or feature implemented

There are a few improvements that are needed to remove the ability for attacks on the network. This is one of them.

What was done?

In this PR we removed data contract validation from check tx, and instead put it in an advanced section in block processing. If it fails we bump the identity nonce for data contract create or identity contract nonce for data contract updates.

Also bumped the min transfer amount from 1 duff to 100 duffs.

How Has This Been Tested?

Created a test that would check_tx for an invalid contract. The check_tx passes, but the block processing marks the transaction as invalid and bumps the identity nonce as expected.

Breaking Changes

Validation changes are breaking.

The min transfer amount is now 100 duffs.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer marked this pull request as draft March 11, 2024 01:55
@QuantumExplorer QuantumExplorer marked this pull request as ready for review March 11, 2024 04:08
…hpay/platform into feat/BetterStateTransitionProcessing
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QuantumExplorer QuantumExplorer merged commit 1196a28 into v1.0-dev Mar 11, 2024
78 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/BetterStateTransitionProcessing branch March 11, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants