Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform)!: identity update can not disable a key it is also adding #1772

Merged
merged 19 commits into from
Mar 14, 2024
Merged

feat(platform)!: identity update can not disable a key it is also adding #1772

merged 19 commits into from
Mar 14, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Mar 14, 2024 •
edited
Loading

Issue being fixed or feature implemented

What was done?

Before this PR we could both add and disable the same key in an identity update.

How Has This Been Tested?

Untested, but also trivial.

Breaking Changes

Slightly breaking, as we are changing consensus validation rules.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

QuantumExplorer and others added 19 commits March 12, 2024 22:56
@QuantumExplorer
a lot of work around errors
d57186a
@QuantumExplorer
more work and fmt
c788c33
@QuantumExplorer
better contract validation
2beae74
@QuantumExplorer
clippy fixes
6784699
@QuantumExplorer
Merge branch 'v1.0-dev' into feat/betterDataContractUpdateProcessing
3244906
@QuantumExplorer
Merge branch 'v1.0-dev' into feat/betterDataContractUpdateProcessing
0354626
@QuantumExplorer
Merge branch 'feat/betterDataContractUpdateProcessing' of github.com:…
7ce3efb 
…dashpay/platform into feat/betterDataContractUpdateProcessing
@QuantumExplorer
fixes for each feature
69c1547
@QuantumExplorer
small fix
81f96fb
@QuantumExplorer
more fixes
1113f3f
@QuantumExplorer
more fixes
cbf2994
@markin-io
fix(sdk): public key security level
fee2b2b
@QuantumExplorer
more fixes for data contract update
e846508
@QuantumExplorer
Merge branch 'feat/betterDataContractUpdateProcessing' of github.com:…
bc03faa 
…dashpay/platform into feat/betterDataContractUpdateProcessing
@QuantumExplorer
adding a identity data contract nonce set to 0 for data contract create
5bfae10
@QuantumExplorer
fixes
4feb611
@QuantumExplorer
feat: use block time instead of state transition key disabled at time
d7ee2f2
@QuantumExplorer
feat: validate that identity update does not disable a key it is adding
650c51e
@QuantumExplorer
Merge branch 'v1.0-dev' into feat/betterIdentityUpdate
1cb760d
@QuantumExplorer QuantumExplorer changed the title feat(platform)!:better identity update feat(platform)!: identity update can not disable a key it is also adding Mar 14, 2024
shumkov
shumkov approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QuantumExplorer QuantumExplorer merged commit 825d963 into v1.0-dev Mar 14, 2024
69 of 70 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/betterIdentityUpdate branch March 14, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuantumExplorer @shumkov @markin-io