Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): dapi client pool should separate platform and core clients #1818

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Apr 15, 2024

Issue being fixed or feature implemented

Connection pool should distinguish between Core and Platform connections

What was done?

Added prefix to key in connection pool, describing type of connection (Core or Platform) to use.

How Has This Been Tested?

Tested using rs-platform-explorer strategy tests against testnet.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review April 15, 2024 11:10
@QuantumExplorer QuantumExplorer merged commit 56a4d88 into v1.0-dev Apr 16, 2024
28 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/dapi-client-conn-pull-type branch April 16, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants