fix(sdk): invalid error returned when identity create fails #1856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
put_to_platform_and_wait_for_response() doesn't return correct error when
broadcast_request_for_new_identity
fails, but it waits until timeout.What was done?
Added return when error occurs
How Has This Been Tested?
Using rs-platform explorer, patched to use invalid asset lock private key when creating identity in
Wallet > Register identity
.BEFORE the fix,
Wallet > Register identity
waits until timeout and then errors with:AFTER the fix
Wallet > Register identity
immediately errors with:Breaking Changes
None
Checklist:
For repository code-owners and collaborators only