Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): background SSL renewal stuck on error #1897

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 19, 2024

Issue being fixed or feature implemented

Dashmate helper stuck during SSL renewal in case of error due to interactive prompt.

Creating user dashmate (1001)
Group exist: ping 999
Adding dashmate to group ping
Starting with UID: 1001, GID: 1001, USER: dashmate, GROUP: ping
Starting dashmate helper
SSL certificate 29b6eb5a0e94592aa9d02ad113f92f24 will expire at Mon Jun 17 2024 23:59:59 GMT+0000 (Coordinated Universal Time). Schedule to obtain at Fri Jun 14 2024 23:59:59 GMT+0000 (Coordinated Universal Time).
Dashmate JSON-RPC API started on port 9000
[STARTED] Check if certificate already exists and not expiring soon
[DATA] Certificate exists but expires in less than 3 days at Mon Jun 17 2024 23:59:59 GMT+0000 (Coordinated Universal Time). Obtain a new one
[SUCCESS] Check if certificate already exists and not expiring soon
[STARTED] Create a certificate
[SUCCESS] Create a certificate
[STARTED] Set up verification server
[SUCCESS] Set up verification server
[STARTED] Start verification server
[SUCCESS] Start verification server
[STARTED] Verify certificate IP address
[DATA]   An error occurred during verification: domain_control_validation_failed
[DATA]
[DATA]     Please ensure that port 80 on your public IP address 54.201.32.131 is open
[DATA]     for incoming HTTP connections. You may need to configure your firewall to
[DATA]     ensure this port is accessible from the public internet. If you are using
[DATA]     Network Address Translation (NAT), please enable port forwarding for port 80
[DATA]     and all Dash service ports listed above.
[DATA] ? Try again? ‣ No / Yes
[DATA]   An error occurred during verification: domain_control_validation_failed
[DATA]
[DATA]     Please ensure that port 80 on your public IP address 54.201.32.131 is open
[DATA]     for incoming HTTP connections. You may need to configure your firewall to
[DATA]     ensure this port is accessible from the public internet. If you are using
[DATA]     Network Address Translation (NAT), please enable port forwarding for port 80
[DATA]     and all Dash service ports listed above.
[DATA] ? Try again? ‣ No / Yes

What was done?

  • Pass noRetry flag to disable prompt for dashmate helper

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from QuantumExplorer as a code owner June 19, 2024 04:53
@shumkov shumkov merged commit 9edcd10 into v1.0-dev Jun 22, 2024
21 checks passed
@shumkov shumkov deleted the fix/dashmate/ssl-renewal-stuck branch June 22, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants