Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: voting proofs work as intended and various fixes #1910

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Jun 27, 2024

Issue being fixed or feature implemented

Voting proofs were not working as intended, now they are.
Cleanup wasn't cleaning up all old votes.
Vote tallies after distribution were not keeping information about masternode vote strength.
Costs of votes were not being taken into account and were not given to pools.

What was done?

Added votes to strategy tests and made a few strategy tests, including distribution.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer requested a review from shumkov as a code owner June 27, 2024 11:41
@QuantumExplorer QuantumExplorer merged commit b33eb5a into feat/contestedDocumentResolutionWithMasternodeVoting Jun 28, 2024
4 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/contestedDocumentResolutionFixes3 branch June 28, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants