Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): state transition broadcast missing contract provider #1913

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Jun 28, 2024

Issue being fixed or feature implemented

Instead of providing contract provider function, some state transition broadcast logic always returned None (meaning the contract was not found).

What was done?

  • Added trait ContractProvider automatically implemented for all ContextProvider objects that makes it easy to retrieve the contract lookup fn, as required by Drive
  • Added method sdk::context_provider()
  • fixed existing logic

How Has This Been Tested?

In TUI, sending masternode votes

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek merged commit ccde6af into feat/contestedDocumentResolutionWithMasternodeVoting Jun 30, 2024
2 checks passed
@lklimek lklimek deleted the fix/sdk-put-st-contract-provider branch June 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants