Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dashmate): enable Core RPC whitelists #1962

Merged
merged 3 commits into from
Jul 16, 2024
Merged

chore(dashmate): enable Core RPC whitelists #1962

merged 3 commits into from
Jul 16, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 16, 2024

Issue being fixed or feature implemented

Since #1883 whitelists were disabled since Core 21 rc.1 didn't support them for complex commands. Core rc2 is released so we can enable whitelists.

What was done?

  • Enabled whitelists in dash.conf
  • Changed quorumplatformsign to quorumsign since we do not support in in Tenderdash v1 yet
  • Updated Core to v21.0.0-devpr6115.db828177 which is basically Core rc2

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from QuantumExplorer as a code owner July 16, 2024 08:44
ogabrielides
ogabrielides approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit d03e2ca into v1.0-dev Jul 16, 2024
21 checks passed
@shumkov shumkov deleted the chore/dashmate/rpc-whitelists branch July 16, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielides ogabrielides ogabrielides approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shumkov @ogabrielides @QuantumExplorer