Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drive): unknown mn_rr fork height #1994

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 24, 2024

Issue being fixed or feature implemented

 2024-07-23T18:58:32.717312Z DEBUG dashcore_rpc: JSON-RPC request: protx ["listdiff",1,5400]
    at /root/.cargo/git/checkouts/rust-dashcore-rpc-474497c1dcebe04a/9e59614/client/src/client.rs:1646 on main ThreadId(1)
    in tenderdash_abci::tracing_span::abci with endpoint: "InitChain", request_id: "e994bea4-b338-47b3-91cb-2721b3553294"

  2024-07-23T18:58:32.717754Z DEBUG dashcore_rpc: JSON-RPC error for protx: RpcError { code: -1, message: "block must be a chain height and not 5400", data: None }
    at /root/.cargo/git/checkouts/rust-dashcore-rpc-474497c1dcebe04a/9e59614/client/src/client.rs:1666 on main ThreadId(1)
    in tenderdash_abci::tracing_span::abci with endpoint: "InitChain", request_id: "e994bea4-b338-47b3-91cb-2721b3553294"

It means the fork is active but Core doesn't have blocks for this height yet.

What was done?

  • Return an error (to retry) if the mn_rr fork height is not chain locked yet

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jul 24, 2024
@shumkov shumkov requested a review from QuantumExplorer as a code owner July 24, 2024 04:05
@shumkov shumkov merged commit 6913319 into v1.0-dev Jul 24, 2024
23 checks passed
@shumkov shumkov deleted the fix/drive/fork-height-is-uknown branch July 24, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants