Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dpns js sdk fix for identity record rename #2001

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

DPNS was having an issue in the JS SDK, this should fix it.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer requested a review from shumkov as a code owner July 24, 2024 20:36
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thephez
Copy link
Collaborator

thephez commented Jul 24, 2024

Some suggestions in #2002 (based on this PR's branch). I think they make sense 🙂

@QuantumExplorer QuantumExplorer added the bug Something isn't working label Jul 24, 2024
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Tried to test and didn't see issues" Ack 😅

@QuantumExplorer QuantumExplorer changed the title fix: dpns js sdk fix fix: dpns js sdk fix for identity record rename Jul 24, 2024
@QuantumExplorer QuantumExplorer merged commit 429c009 into v1.0-dev Jul 24, 2024
22 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/dpnsJSSDKfix branch July 24, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants