fix(strategy-tests): document delete transitions were selecting identity in complicated way #2006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Document delete transitions were using identity callback function to get the identity for signing, which was overcomplicated for the current purposes. That method is the way to do it if we're trying to delete documents that already exist, but for now, we're just deleting documents that were also created in the current strategy. In the future, I guess it would be better to have it done the original way but for now, this is simpler.
What was done?
Just get the identity from the current_identities
This means you can only delete documents that were created in the current strategy, but it's good enough for a first implementation. No other aspects of strategy tests in TUI really are compatible with previous strategy tests anyways.
How Has This Been Tested?
TUI
Breaking Changes
Checklist:
For repository code-owners and collaborators only