Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(strategy-tests): document delete transitions were selecting identity in complicated way #2006

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

pauldelucia
Copy link
Member

@pauldelucia pauldelucia commented Jul 25, 2024

Issue being fixed or feature implemented

Document delete transitions were using identity callback function to get the identity for signing, which was overcomplicated for the current purposes. That method is the way to do it if we're trying to delete documents that already exist, but for now, we're just deleting documents that were also created in the current strategy. In the future, I guess it would be better to have it done the original way but for now, this is simpler.

What was done?

Just get the identity from the current_identities

This means you can only delete documents that were created in the current strategy, but it's good enough for a first implementation. No other aspects of strategy tests in TUI really are compatible with previous strategy tests anyways.

How Has This Been Tested?

TUI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pauldelucia pauldelucia merged commit 50d8f09 into v1.0-dev Jul 25, 2024
17 of 18 checks passed
@pauldelucia pauldelucia deleted the fix/document-delete-in-strategies branch July 25, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants