-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: turn off ak's typetracer _new checks during optimize #486
feat: turn off ak's typetracer _new checks during optimize #486
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
- Coverage 93.06% 93.01% -0.06%
==========================================
Files 23 23
Lines 3290 3336 +46
==========================================
+ Hits 3062 3103 +41
- Misses 228 233 +5 ☔ View full report in Codecov by Sentry. |
During |
If you specify the lines of code that should be avoided, I'll add them to this PR (with only one global switch for all). |
OK, but that's not actually something we've been talking about in our benchmarking recently. I suppose the columns opt is actually the only place we need this right now (although it would be nice throughout graph build time too). I wouldn't be opposed to a public function that can turn the flag and keep it that way for the whole session. |
Yeah I haven't fully thought through or experienced the user-side lifecycle of |
OK, will merge this now, and we can add more blocks or set a global state in the future, if we decide. |
Will have no effect until scikit-hep/awkward#3054 is out
@lgray , any other places we need this optimisation?