Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax dask version requirement and use a better check for Task #563

Merged
merged 10 commits into from
Dec 17, 2024
Merged

fix: relax dask version requirement and use a better check for Task #563

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
30f70dd
better check if dask is using Tasks
lgray Dec 17, 2024
cf39b38
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 17, 2024
731ce1d
revert pins
lgray Dec 17, 2024
64b2a66
only check blockwise for Task; grab Task, TaskRef from blockwise
lgray Dec 17, 2024
49a6d62
take _task_spec classes from blockwise
lgray Dec 17, 2024
dd1e5dd
grab TaskRef from blockwise
lgray Dec 17, 2024
407401d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 17, 2024
481d1d9
appease mypy
lgray Dec 17, 2024
86054f0
appease mypy
lgray Dec 17, 2024
a88502f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ classifiers = [
]
dependencies = [
"awkward >=2.5.1",
"dask >=2024.12.0;python_version>'3.9'",
"dask >=2023.04.0;python_version<'3.10'",
"dask >=2023.04.0",
"cachetools",
"typing_extensions >=4.8.0",
]
Expand Down
5 changes: 2 additions & 3 deletions src/dask_awkward/layers/layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,15 @@
from typing import TYPE_CHECKING, Any, Literal, Protocol, TypeVar, Union, cast

import dask

_dask_uses_tasks = hasattr(dask, "_task_spec")

from dask.blockwise import Blockwise, BlockwiseDepDict, blockwise_token
from dask.highlevelgraph import MaterializedLayer
from dask.layers import DataFrameTreeReduction
from typing_extensions import TypeAlias

from dask_awkward.utils import LazyInputsDict

_dask_uses_tasks = hasattr(dask, "_task_spec") and hasattr(dask.blockwise, "Task")
lgray marked this conversation as resolved.
Show resolved Hide resolved

if _dask_uses_tasks:
from dask._task_spec import Task, TaskRef

Expand Down
Loading