Fix flaky test_worker_reconnects_mid_compute
#5227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
approved these changes
Aug 18, 2021
jrbourbeau
changed the title
test_worker_reconnects_mid_compute
|
Alas this was insufficient. These two tests are currently extremely flaky on Windows 3.8 exclusively (I can't explain that); e.g. https://github.com/crusaderky/distributed/runs/3433363473?check_suite_focus=true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test condition is wrong since we cannot reliably state that worker B managed to receive the task and transition it to executing before the heartbeat is triggered. If that happens, we'll never receive a second result. We want to ensure in these tests that the original result of the disconnecting worker is logged and this is what the new test condition asserts