Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler task transition tracing #5954

Closed
wants to merge 26 commits into from
Closed

Scheduler task transition tracing #5954

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
2957f38
Initial commit
sjperkins Mar 16, 2022
e2f54a3
Defer to parent stimulus in transition_processing_memory
sjperkins Mar 17, 2022
5307c0e
Change exception_blame type to TaskState | None
sjperkins Mar 17, 2022
c229a65
Change exception_blame back to TaskState and make stimulus_id's 'str …
sjperkins Mar 17, 2022
d010b2d
Remove stimulus_id type annotations
sjperkins Mar 17, 2022
6cfc1ef
Add stimulus_id's in various places
sjperkins Mar 17, 2022
2ced7c1
Merge branch 'main' into scheduler-task-transition-tracing
sjperkins Mar 17, 2022
cb15e74
Add stimulus_id's in state mutating handlers
sjperkins Mar 18, 2022
21302bd
Reintroduce log handlers
sjperkins Mar 18, 2022
2cf4a8a
Merge branch 'main' into scheduler-task-transition-tracing
sjperkins Mar 21, 2022
1670906
Checkpoint running test suite
sjperkins Mar 21, 2022
8c577f8
Remove cruft
sjperkins Mar 21, 2022
dabfefe
Add stimulus_id to scheduler transition_log
sjperkins Mar 21, 2022
be43e63
Support worker + client stimuli, stimuli in http
sjperkins Mar 22, 2022
45bf7de
assert_worker_story -> assert_story and test scheduler story
sjperkins Mar 22, 2022
80ffddf
Remove stimulus_id's from code paths that don't change TaskState
sjperkins Mar 22, 2022
a246197
Merge branch 'main' into scheduler-task-transition-tracing
sjperkins Mar 22, 2022
1a72c88
Further stimulus_id changes in worker.py
sjperkins Mar 22, 2022
7c30cfa
Add missing stimulus_id to free-keys worker msg
sjperkins Mar 22, 2022
b0fd952
Review changes
sjperkins Mar 25, 2022
90039fb
Merge branch 'main' into scheduler-task-transition-tracing
sjperkins Mar 25, 2022
3affd07
Fix stray assert_worker_story -> assert_story
sjperkins Mar 25, 2022
925c2bd
Used new_stimulus_id in Worker.execute
sjperkins Mar 25, 2022
6e58f91
Revert "Used new_stimulus_id in Worker.execute"
sjperkins Mar 25, 2022
6d6a0ee
Merge branch 'main' into scheduler-task-transition-tracing
sjperkins Mar 31, 2022
7bf0117
Different stimulus_id's success/failure in Worker.execute
sjperkins Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion distributed/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,7 +1377,12 @@ def _release_key(self, key):
st.cancel()
if self.status != "closed":
self._send_to_scheduler(
{"op": "client-releases-keys", "keys": [key], "client": self.id}
{
"op": "client-releases-keys",
"keys": [key],
"client": self.id,
"stimulus_id": f"client-release-key-{time()}",
sjperkins marked this conversation as resolved.
Show resolved Hide resolved
}
)

async def _handle_report(self):
Expand Down
Loading