Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_in_flight_lost_after_resumed #6372

Merged

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented May 19, 2022

This test has been flaky occasionally because it is quite timing sensitive. Due to allow_other_workers there is a remote chance that the key is actually assigned to the wrong worker (haven't investigated why) such that the key is never fetched/in-flight. This makes the logic more robust

Encountered in #6363

@fjetter
Copy link
Member Author

fjetter commented May 19, 2022

I opened #6373 for the test failure

@github-actions
Copy link
Contributor

Unit Test Results

       15 files  ±0         15 suites  ±0   7h 26m 0s ⏱️ + 9m 36s
  2 804 tests ±0    2 722 ✔️  - 3    78 💤  - 1  4 +4 
20 794 runs  ±0  19 867 ✔️  - 5  923 💤 +1  4 +4 

For more details on these failures, see this check.

Results for commit c247d97. ± Comparison against base commit 4d29246.

@fjetter fjetter merged commit 33fc50c into dask:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant