Clean up cluster process reaping
#6840
Conversation
| @@ -590,15 +590,13 @@ def cluster( | |||
| nanny=False, | |||
| worker_kwargs=None, | |||
| active_rpc_timeout=10, | |||
| shutdown_timeout=20, | |||
There was a problem hiding this comment.
Unused in codebase
| scheduler_kwargs=None, | ||
| config=None, | ||
| ): | ||
| worker_kwargs = worker_kwargs or {} | ||
| scheduler_kwargs = scheduler_kwargs or {} | ||
| config = config or {} | ||
|
|
||
| ws = weakref.WeakSet() |
There was a problem hiding this comment.
Unused in function (and workers_by_pid already held strong references to the Process instances anyway). Plus we do want strong references, so that we can kill them at the end. It's not like garbage-collecting a Process instance means the actual OS process will be cleaned up.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 32m 50s ⏱️ + 16m 29s For more details on these failures, see this check. Results for commit 376b526. ± Comparison against base commit e1f3779. |
|
Anyone able to review this? @graingert or @hendrikmakait? |
Follow-up addressing #6829 (comment)
pre-commit run --all-files