Remove second mypy run from pre-commit #7344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a second mypy check that runs in a platform compat mode for windows in #7094
Executing a single mypy check can take a significant amount of time. Below you can see the timings for me when running all hooks. As you can see, mypy takes about 15s on my machine. Adding an additional, mostly redundant 15s to every commit is not justified.
It's also worth pointing out that we're not running this for every python version even though mypy potentially is having the same problem there, see also python/mypy#10747
cc @crusaderky you added this. Any strong objections?