Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bytes/str discrepancy after PyNVML update #7544

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

pentschev
Copy link
Member

A PyNVML update has changed how some objects were previously returned bytes but now return str, which is now handled appropriately with this change.

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       24 files  ±0         24 suites  ±0   10h 48m 15s ⏱️ - 10m 48s
  3 337 tests ±0    3 232 ✔️  - 1     104 💤 ±0  1 +1 
39 342 runs   - 1  37 472 ✔️ +2  1 869 💤  - 4  1 +1 

For more details on these failures, see this check.

Results for commit fca95c0. ± Comparison against base commit ca10a7c.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants