implement wait_for using asyncio.timeout() on 3.11 #7571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 24 files ±0 24 suites ±0 10h 29m 33s ⏱️ - 5m 3s Results for commit 85dcc7b. ± Comparison against base commit 790d852. ♻️ This comment has been updated with latest results. |
2 tasks
graingert
force-pushed
the
asyncio-wait-for-using-asyncio-timeout
branch
3 times, most recently
from
ce86475 to
31f105c
Compare
…fusion with utils.wait_for
using asyncio.wait_for in utils_test.gen_test.<locals>.async_fn_outer spawns a new child task which has the extra effect of waiting an `await asyncio.sleep(0)` after every test before running utils_test.check_instances. When using `async with asyncio.timeout(t):` only the `asyncio.current_task()` is used and so this extra sleep is removed. This extra sleep is enough for the `CommClosedError` to be raised in the `test_listen_connect(_ws).<locals>.handle_comm` task. I proved this by checking that both test_listen_connect and test_listen_connect_wss both pass after restoring `asyncio.wait_for` in `only utils_test.gen_test.<locals>.async_fn_outer` or adding `asyncio.sleep(0)` to the end of the tests.
graingert
force-pushed
the
asyncio-wait-for-using-asyncio-timeout
branch
from
31f105c to
85dcc7b
Compare
fjetter
reviewed
Feb 23, 2023
Comment on lines
+1803
to
+1812
| if sys.version_info >= (3, 11): | ||
|
|
||
| async def wait_for(fut: Awaitable[T], timeout: float) -> T: | ||
| async with asyncio.timeout(timeout): | ||
| return await fut | ||
|
|
||
| else: | ||
|
|
||
| async def wait_for(fut: Awaitable[T], timeout: float) -> T: | ||
| return await asyncio.wait_for(fut, timeout) |
There was a problem hiding this comment.
Not a big deal but we also have a compatibility module with things like this
fjetter
approved these changes
Feb 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7570
pre-commit run --all-files