Skip to content
This repository has been archived by the owner on Aug 13, 2018. It is now read-only.

Always set KNIT_LANG, even if envvars passed in #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always set KNIT_LANG, even if envvars passed in #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion knit/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,8 @@ def start(self, cmd, num_containers=1, virtual_cores=1, memory=128,
A yarn application ID string
"""
files = files or []
envvars = envvars or {'KNIT_LANG': self.lang}
envvars = {} or envvars.copy()
envvars.setdefault('KNIT_LANG', self.lang)
for k, v in envvars.items():
if not isinstance(k, str) or not isinstance(v, str):
raise ValueError('Environment must contain only strings (%s)'
Expand Down