Remove type promotion tests #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What would be the strategy for testing type promotion compliance across spec versions moving forward? |
Our primary tests cover type promotion! I have little motivation maintaining tests specific to type promotion given they already get covered and any function/method testing is pretty finnicky to setup. |
|
It's still likely that at some point in the future we'll want some way to distinguish different parts of the test suite. That extends beyond just type promotion, though. I agree that test_type_promotion is redundant at this point, so we should be OK with removing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #143. I'm exploring complex support and it feels even more weird to have these tests, given the machinery we'd need for #20.