Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 04-faceting-and-filtering.md #165

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Conversation

drjwbaker
Copy link
Collaborator

Added a column name for the 'Let's create a text facet' exercise. The wording here requires you to name a column. As a general comment, I noticed when prepping to teach this lesson that it tends to not mention a column when asking the instructor to demo a feature. I chose a column in advance to demo. Your approach (not naming a column) may be deliberate, so please feel free to reject this PR and rewrite in a non-column specific manner!

Added a column name for the 'Let's create a text facet' exercise. The wording here requires you to name a column. As a general comment, I noticed when prepping to teach this lesson that it tends to not mention a column when asking the instructor to demo a feature. I chose a column in advance to demo. Your approach (not naming a column) may be deliberate, so please feel free to reject this PR and rewrite in a non-column specific manner!
@ostephens ostephens merged commit 3bf0bdc into gh-pages Sep 25, 2017
@ccronje ccronje deleted the drjwbaker-patch-4 branch December 17, 2017 02:55
jezcope pushed a commit to jezcope/library-openrefine that referenced this pull request Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants